Boshen

Results 565 comments of Boshen

@ghiden I can't reproduce this :-(

> Found 1 possible coverage files: coverage.out You need to upload the single .xml coverage file, nothing else.

@shyandsy Take a look at the accepted files, https://docs.codecov.com/docs/supported-report-formats You need to generate one of these accepted files.

> Would you like to create a PR for this issue? This is way too complicated for me, I couldn't find the root cause ...

It seems `.with_links(false)` sets `LinkStyle::Text`, then it got omitted here and the link stopped showing up 😂 : https://github.com/zkat/miette/blob/714334098a92c77fb6b962e627defab7e16b540d/src/handlers/graphical.rs#L160 should this be `self.links != LinkStyle::None`?

@MichaReiser found 2 crashing points for you to play with 😁 * 2022.04.09: * `/=0*_:m/=/*_:|` crashing point `rome_js_parser/src/parser.rs:213` * `([=[(p[=[(p%]>([=[(p[=[(` crashing point `rome_js_parser/src/parser.rs:213` * `(--(((--$?:

@MichaReiser * 2022.04.11: * `rome_js_parser/src/parser/rewrite_parser.rs:87:9` * ` ++0 [{+` * `++ \\ [--()()(-

@xunilrj since you are working on the lexer * 2022.04.11: * `rome_js_parser/src/lexer/mod.rs:512:9` * `+\\u{A` `+\\u{C`

@MichaReiser Assignment is hard and no unwrap is safe 😢 * 2022.04.14 b0b0b36 * rome_js_parser/src/syntax/assignment.rs:71:61 * `(([zAgRvz=[=(e{V{` * `({[>[[ =\\c{`

The parser seems pretty solid now, the fuzzer can still detect some panics but the input is super long: `panicked at 'The parser is no longer progressing. Stuck at '?'...