Boshen

Results 565 comments of Boshen

### Merge activity * **Oct 12, 12:29 AM EDT**: The merge label '0-merge' was detected. This PR will be added to the [Graphite merge queue](https://app.graphite.dev/merges?org=oxc-project&repo=oxc) once it meets the requirements....

> Hmm... I'll see what I can do. I'm not really 100% happy with how markdown rendered either. Side note: for other data sources I ended up parsing to another...

Thanks for the quick response! While we are at it, my weirdly added doc comment https://github.com/oxc-project/oxc/blob/3671b5c4d0a56a2edd005bbd8710036ee61376d2/crates/oxc_cli/src/command/lint.rs#L79 produced something that looks like a missing newline ``` **Allowing / Denying Multiple Lints**###...

https://github.com/toeverything/AFFiNE/blob/b0ad36425d6299d31a20ecdad795916af583dd02/.eslintignore#L2 My guess is the ignore match here. Specifying `packages/backend/server/dist` forces linting this path.

Probably a bug, can you assign this to me so I don't forget?

The referenced fix will display the following output, feel free to fix these before our next release. ``` oxlint -c oxlint.json --tsconfig tsconfig.json --import-plugin × eslint-plugin-import(no-cycle): Dependency cycle detected ╭─[packages/backend/server/src/core/features/index.ts:3:28]...

We need to spend some time to finish printing strings and number https://github.com/evanw/esbuild/blob/ac54f06dbfb146aee3c3c7bea174c7cd248d3194/internal/js_printer/js_printer.go#L64 let a = '\udf06' is broken because it's a a surrogate number https://github.com/evanw/esbuild/blob/ac54f06dbfb146aee3c3c7bea174c7cd248d3194/internal/js_printer/js_printer.go#L197

I finally understood where the problem is after looking at other implementations written in Rust: https://github.com/boa-dev/boa/blob/532c00862c72d1e7a284a37ba5bb31ec20d2d8a9/core/parser/src/lexer/string.rs#L147 Our implementation was copied from jsparagus, where they didn't implement this part yet https://github.com/oxc-project/oxc/blob/92ee77487f0fb929f7f3d8098906c519330198a7/crates/oxc_parser/src/lexer/unicode.rs#L239...

I'm super confused right now, how should we store these two utf16 strings `"\udf06"` and `"\\udf06"` in `StringLiteral::value` as `Vec`? Should we change `StringLiteral::value` to `Vec` instead? @andreubotella Can you...