Boshen comments

Results 565 comments of


                                            Boshen

fix(minifier): fix string concatenation for lone surrogates

This is a lot of code to support lone surrogates, I'll take a deeper look later.

linter: `eslint/no-undef` does not know about native types

`no-undef` is still under nurser, PRs welcome! The fix should be checking for symbol flags.

fix(semantic): correctly resolve binding for return type of functions

### Merge activity * **Nov 26, 10:41 AM EST**: The merge label '0-merge' was detected. This PR will be added to the [Graphite merge queue](https://app.graphite.dev/merges?org=oxc-project&repo=oxc) once it meets the requirements....

Should class declarations contain a binding for class name in scope for the class?

Do we have a consensus on this issue?

Should class declarations contain a binding for class name in scope for the class?

No consensus, close as stale. We'll conform to the container concept in tsc.

perf(lexer): pad `Token` to 16 bytes

I'm not seeing any difference, both are `size = 16 (0x10), align = 0x4`. What are property do I need to inspect? Can this be a compile time check? We...

feat(linter): add `eslint/dot-notation`

@camc314 would be great if you can finish this, by copying over what the minifier does.

Path alias not resolved

``` DEBUG oxc_resolver: options: ResolveOptions { cwd: Some("/home/projects/github-gzbuzr-qutnhv57"), tsconfig: Some(Manual(TsconfigOptions { config_file: "/home/projects/github-gzbuzr-qutnhv57/tsconfig.json", references: Disabled })), alias: [], alias_fields: [], condition_names: ["import", "default", "module", "node"], enforce_extension: Disabled, exports_fields: [["exports"]], imports_fields:...

feat(allocator)!: replace `bumpalo` with `bump-scope`

Thank you for working on this. Close as stale, but feel free to come back and make improvements.

[Bug]: since beta.47, failed to build on jenkins pipeline docker, error 'Cannot resolve entry module vite.config.ts.'

https://github.com/oxc-project/oxc-resolver/pull/901