Boshen comments

Results 565 comments of


                                            Boshen

feat(parser): use `BindingIdentifier` for `namespace` declaration names

Let me check the spec.

feat(parser): use `BindingIdentifier` for `namespace` declaration names

This is incorrect, it's not a binding identifier. Although the "global" fix is correct in the next PR.

feat(parser): use `BindingIdentifier` for `namespace` declaration names

> How should we make a namespace's symbol is available from the AST? Can you elaborate?

feat(parser): use `BindingIdentifier` for `namespace` declaration names

> > > How should we make a namespace's symbol is available from the AST? > > > > > > Can you elaborate? > > `BindingIdentifier` has a `symbol_id`...

feat(parser): use `BindingIdentifier` for `namespace` declaration names

I need proof and reference from tsc to confirm this is a BindingIdentifier.

feat(parser): use `BindingIdentifier` for `namespace` declaration names

I checked binder.ts It calls `function bindModuleDeclaration(node: ModuleDeclaration) {` and then ``` function declareModuleSymbol(node: ModuleDeclaration): ModuleInstanceState { const state = getModuleInstanceState(node); const instantiated = state !== ModuleInstanceState.NonInstantiated; declareSymbolAndAddToSymbolTable( node, instantiated...

[POC] perf(ast): use pointer instead of slice for identifier names

Unfortunately we are not building a runtime. We sometimes need duplicated information for ease of use.

[ts] bug with arrow functions in ternaries

> Some pointers: https://github.com/oxc-project/oxc/issues/9215#issuecomment-2667871128 To save a bit of clicking: TypeScript has the following syntax constraint: https://github.com/microsoft/TypeScript/blob/246507f7f90e08a330fc9f63c1b11c2e706d9193/src/compiler/parser.ts#L5583 https://github.com/microsoft/TypeScript/blob/246507f7f90e08a330fc9f63c1b11c2e706d9193/src/compiler/parser.ts#L5501-L5524

feat(minify): add directives option

> At present, it seems that adding this configuration is still quite necessary can you elaborate your use case? I try to avoid adding options until it's necessary for a...

Implement `serde::Serialize` on AST types via `#[generate_derive]`

What's our next steps?