Biswapriyo Nath

Results 467 comments of Biswapriyo Nath

I think this has been fixed in current main branch.

I do not mean to hurt author's attempt. The code seems to be a reverse engineered version of what ws2_32 does internally. Should a project depend on internal behavior of...

What compiler toolchain are you using? openjpeg can be compiled without any error in msys2/mingw-w64 toolchain. See the build command here https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-openjpeg2/PKGBUILD

In master branch, this was solved different way. If required I can create another PR to make things similar in master branch. Setting COMPILE_FLAGS with `set_target_properties` was [deprecated](https://cmake.org/cmake/help/latest/prop_tgt/COMPILE_FLAGS.html). So, using...

The name "WIN32" does not mean 32 bit only. "WIN32" is true for any Microsoft Windows OS, irrespective of CPU architecture. See more https://cmake.org/cmake/help/latest/variable/WIN32.html

Here https://docs.microsoft.com/en-us/windows/win32/api/dpapi/nf-dpapi-cryptunprotectdata

> The logic of change to line 533 leaves possibility of Unix, Win64, Linux, et al. Doesn't previous logic also include those possibility? There is no Win64. WIN32 includes Win64....

My apology, I am out of ideas 😔

> it seems to only add MINGW to the list of environments that would be allowed by the clause Right.