Sam Atkins

Results 346 comments of Sam Atkins

I'm not involved with the update process, but I do know it's not done very often. My impression is it's roughly every couple of weeks, unless something urgent comes up.

Hi, the code looks good, but please adjust your commit title/message to follow our [policy](https://github.com/LadybirdBrowser/ladybird/blob/master/CONTRIBUTING.md#code-submission-policy). A test would also be nice ideally, but I don't know how you'd actually write...

Hi there, thanks for the report! > I'm interpreting this to mean that `InvertCalculationNode` should only be used on `Integer` or `Number`. I don't think that's the correct interpretation. It...

I think as the crash itself is gone this can be closed.

It looks like this got a little bit mangled. Can you please combine this into a single commit as it's a single change, and also correct the comments? The way...

Hi! Welcome to Ladybird. :^) Please add a layout test that demonstrates this. (So, it fails without this change, and passes with it.) You can find examples in `Tests/LibWeb/Layout`. Put...

`Meta/ladybird.sh test LibWeb` will run all the LibWeb tests.

Hi, the verification failure you're seeing is based on a 4-month-old version of the code. I assume you're building from the nixpkgs version. Can you confirm that you see this...

Hi there! Thanks for looking into this. I don't think this is the right fix though. We shouldn't modify the CSS, as we want it to still work even if...

No worries! Feel free to ask in the Discord channels if you want some pointers.