ladybird icon indicating copy to clipboard operation
ladybird copied to clipboard

LibWeb/Layout: Implement justify-content for column spacing in grid

Open neil-ptr opened this issue 1 year ago • 3 comments

Description

Before, we were only adding gap tracks if the css property gap: ... had an explicit property. This PR makes sure we always add gap tracks between column tracks (as well as gaps between row tracks). Also, this implements extra space distribution to column gaps as specified in justify-content for space-around, space-between and space-evenly

neil-ptr avatar Oct 02 '24 05:10 neil-ptr

Hi! Welcome to Ladybird. :^)

Please add a layout test that demonstrates this. (So, it fails without this change, and passes with it.) You can find examples in Tests/LibWeb/Layout. Put the HTML file in Tests/LibWeb/Layout/input/grid somewhere, and then run Tests/LibWeb/rebaseline-libweb-test /absolute/path/to/your/test/file.html to generate the output for it.

AtkinsSJ avatar Oct 02 '24 09:10 AtkinsSJ

@AtkinsSJ how do I run the layout tests after I generate the output for it?

neil-ptr avatar Oct 03 '24 03:10 neil-ptr

Meta/ladybird.sh test LibWeb will run all the LibWeb tests.

AtkinsSJ avatar Oct 03 '24 07:10 AtkinsSJ