Sam Atkins
Sam Atkins
Just realised in the shower: Formatter also doesn't handle the case of being called with only 1 arg, which again happens when called from `trace()`, `group()` and `groupCollapsed()`. New changes:...
@terinjokes Any thoughts on this so far?
Just remembered this PR again, and rebased it on the main branch. Is there anything I still need to do to get verified as a WHATWG participant? I registered for...
Thanks for the merge! :^)
> A few of these are reading into a byte buffer a-la `ByteBuffer::create_uninitialized`, but of a static size. Can we use e.g. `Array` instead to avoid extra allocation? See: [`master`/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GeneratorUtil.h#L337](https://github.com/SerenityOS/serenity/blob/master/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GeneratorUtil.h?rgh-link-date=2022-09-13T14%3A16%3A45Z#L337)...
Ohhh, so we don't need to worry about OOM for stack allocation? That makes sense.
I've replaced use of `ByteBuffer::create_uninitialized()` with an `Array`. Also, using `PAGE_SIZE` instead of 4096 as suggested in another PR.
I think I've found the simplest repro for this: 1. Run `br foobarbaz` 2. Close Browser It fails to load, but the UI never updates to say there was an...
> I would like to work on this if possible. I'm a beginner here, so would appreciate any advice! Welcome! The best place to ask questions is on our Discord...
> This ticket is extremely similar to #11862 . Could we potentially edit the title/description to make it a bit more distinct? > > I will shortly have a PR...