Sam Atkins

Results 325 comments of Sam Atkins

Currently, loading https://www.chess.com/play/online makes Ladybird freeze. Notably RequestServer is using CPU constantly. EDIT: Same with #3676 applied.

There are no plans for this, because it's not even been discussed before and we're not ready to start thinking about it. We don't yet save any of that data...

This looks good to me, is there something preventing it being merged?

> I'm not sure if it would be better to convert name to lower case at some earlier point during parsing. Maybe. Needs checking whether serialization ever expects the original...

A couple of commit titles you've written "selector" when you want "property". We generate some bounds-checking code for properties (in `PropertyID.h`) that you can use in some of these, though...

> Not sure if [dzfrias/ladybird@`568de76`/Userland/Libraries/LibWeb/CSS/StyleComputer.cpp#L2218](https://github.com/dzfrias/ladybird/blob/568de76fd26c1f5349132834e236a43f3cd5cfbc/Userland/Libraries/LibWeb/CSS/StyleComputer.cpp#L2218) is also relevant here. I'm not sure why `absolutize_values` doesn't mess everything up since it's also using root font metrics... regardless, it didn't cause any...

I don't **think** there's a spec algorithm. Most of the CSS specs just tell you what the end result should be and you have to figure it out yourself. The...

The results are a big improvement and the code looks fine to me (though I'm not a layout person :sweat_smile: ) but of course a lot of tests still need...

I just noticed that you've described in each of the `LibWeb: Fix test` commits how the test was modified. You don't need to do that. :sweat_smile: Please just squash all...

> Just so I understand though - there will probably still be some tests that are legitimately failing (e.g. table/nested-table-box-width.html) in the end (not because of this change, but because...