puter icon indicating copy to clipboard operation
puter copied to clipboard

Merged changes not showing up on Puter.com after days?

Open crisdosaygo opened this issue 1 year ago • 2 comments

#147 was merged 4 days ago but the change did not show up yet.

For references the change (in UIWindow here) is:

Adding allow-storage-access-by-user-activation which is important for permitting Safari to ask the user if the embedded app can use cookies, which enhances security, privacy and user consent.

aka

`...
                        sandbox="allow-forms allow-modals allow-pointer-lock allow-popups 
allow-popups-to-escape-sandbox allow-same-origin allow-scripts 
allow-top-navigation-by-user-activation allow-downloads allow-presentation 
allow-storage-access-by-user-activation"></iframe>`;

I tried checking if it was present across two different apps: 1 created before the merge in Dev Center and 1 created after. Yet neither had this change that is currently in main:

You can see in the above screenshots the UIWindow iframe is missing the allow-storage-access-by-user-activation added in the merge, even tho it's present in main. I know @jelveh said it might take a while, but I thought that meant "hours". Does it really mean "days"? 😹 😆

For the apps above it's okay as I've already modified them to not depend on the 3rd-party (set in cross-domain iframe) cookies that the above change allows access to via a user request. But as major browsers phase out 3rd-party cookies in 2024, and Puter uses an iframe embedding model for apps, it would be wise add this feature to broaden the types of app experiences that can be built on Puter, as any apps that incorporate content from across other origins to have rich back-end backed experiences of their own (like these two web browsers, above) will encounter the same issues with cookie authentication.

To see if this only affected #147, I also checked 2 other random PRs from the last 5 days and compared their changes with the current bundle.min.js and the changes from:

  • #162
  • #138

also are not present.

I know it's not easy to run a backend service and plus a front-end GitHub repo, but some kind of note about how changes are merged in to be served by the backend after merging at GitHub or how long that takes and why would enhance the contributor experience.

crisdosaygo avatar Mar 25 '24 01:03 crisdosaygo

I'm not involved with the update process, but I do know it's not done very often. My impression is it's roughly every couple of weeks, unless something urgent comes up.

AtkinsSJ avatar Mar 25 '24 11:03 AtkinsSJ

Oh, thanks @AtkinsSJ for your words from experience! :)

crisdosaygo avatar Mar 25 '24 13:03 crisdosaygo