Sam Atkins comments

Results 325 comments of


                                            Sam Atkins

LibWeb: Add fuzzing test for calc() usage

Changes: - Add test cases that don't use `var()`. - Rename the test. - Add in a fix for `grid-template-*` properties serializing to the empty string.

LibWeb: Add fuzzing test for calc() usage

Rebased because I merge-conflicted myself with the `grid-*-gap` change. :laughing:

LibWeb: Add fuzzing test for calc() usage

Just corrected the commit message, there were a couple more properties I hadn't noticed I'd fixed. :laughing:

LibWeb: Load fonts with Fetch

Changes: CLion and I both missed that we have fuzzers that create WOFF/WOFF2 fonts.

LibGC: Make GC::Ptr, GC::Ref, and GC::Root formattable

Changes: Added GC::Root too.

LibGC: Make GC::Ptr, GC::Ref, and GC::Root formattable

After the discord discussion where we couldn't actually decide how pointer formatting should work, and that not being able to format GC pointers keeps bothering me, I'm going to go...

Arrow marker on `<details>` element doesn't update

Pinging @kalenikaliaksandr - I bisected this to 9b26f7eb0faaca63ee9109c6eda44c82a6acfeaf

LibWeb/Tests: Add Ref, Layout, and Screenshot test support to `add_libweb_test.py`

> I'll fix this but I'm not understanding the mis-use case yet. What could you do incorrectly that would make a test that doesn't get run? `Tests/LibWeb/add_libweb_test.py some/subdir/test.html ref` creates...

LibWeb/Tests: Add Ref, Layout, and Screenshot test support to `add_libweb_test.py`

This has a conflict - the documentation changes now need to go in `Documentation/Testing.md`. Worrying about subdirectories can be deferred for now. I think making those test types allow subdirectories...

LibWeb/Tests: Add Ref, Layout, and Screenshot test support to `add_libweb_test.py`

In #2175 I resolved the subdirectory issue by making Ref/Screenshot tests use the same directory structure as the others (allowing tests in subdirectories). However, the tests now go in `Ref/input`...