Duo Zhang comments

Results 364 comments of


                                            Duo Zhang

HBASE-20904 Prometheus /metrics http endpoint for monitoring

Please take a look at the findbugs issue?

HBASE-27129 Add a config that allows us to configure region-level sto…

No hurry :)

HBASE-26045 Master control the global throughput of all compaction servers

We'd better rebase the branch first? On master, we decoupled HRegionServer and HMaster so there is already a base class for HRegionServer and HMaster, which is conflict with the this...

HBASE-25217 [Metrics] Add metrics for Call in IPC response queue

> Seems there's no way to add this metrics for NettyRpcServer I think it is also very easy? Just modify `NettyRpcServerResponseEncoder`. Before ctx.write, call `addCallToResponseQueue`, and in the callback, call...

HBASE-26217 Clean shared state pollution to avoid flaky tests.

Thanks for the PR. It is always good that we have developers want to clean up tests code. But what I do not understand is, we always create a new...

HBASE-27132 Log archiving fail cause regionserver abort

What is the jira issue for this PR? And mind explaining a bit about the problem?

HBASE-27132 Log archiving fail cause regionserver abort

> > What is the jira issue for this PR? And mind explaining a bit about the problem? > > when "hbase.regionserver.logroll.period" set 600000 and "hbase.master.hfilecleaner.ttl" set 1800000 Under high...

No content to map due to end-of-input

看起来是读到的文件是空的所以json parse失败了？

jodis如何保证proxy下线时获取的client可用？（ZK通知有延迟、感知proxy下线需要时间）

会的，这个按照目前jodis的设计没法避免

jodis如何保证proxy下线时获取的client可用？（ZK通知有延迟、感知proxy下线需要时间）

Jodis就是在Jedis上简单包了一层，你之后请求出错什么的都直接是Jedis处理了，Jodis那个wrapper啥信息也拿不到。想支持failover重试的话得大改了