HBASE-27252 Clean up error-prone findings in hbase-it

[apurtell]

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Comment
+0 :ok:	reexec	0m 33s	Docker mode activated.
-0 :warning:	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 :green_heart:	mvninstall	2m 26s	master passed
+1 :green_heart:	compile	0m 16s	master passed
+1 :green_heart:	shadedjars	3m 58s	branch has no errors when building our shaded downstream artifacts.
+1 :green_heart:	javadoc	0m 11s	master passed
		_ Patch Compile Tests _
+1 :green_heart:	mvninstall	2m 9s	the patch passed
+1 :green_heart:	compile	0m 16s	the patch passed
+1 :green_heart:	javac	0m 16s	hbase-it generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 :green_heart:	shadedjars	3m 57s	patch has no errors when building our shaded downstream artifacts.
+1 :green_heart:	javadoc	0m 9s	the patch passed
		_ Other Tests _
+1 :green_heart:	unit	0m 36s	hbase-it in the patch passed.
		16m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/4662
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux bb80ad9d78d4 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / a3eeab8c56
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/1/testReport/
Max. process+thread count	555 (vs. ulimit of 30000)
modules	C: hbase-it U: hbase-it
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Comment
+0 :ok:	reexec	1m 12s	Docker mode activated.
-0 :warning:	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 :green_heart:	mvninstall	3m 23s	master passed
+1 :green_heart:	compile	0m 24s	master passed
+1 :green_heart:	shadedjars	5m 1s	branch has no errors when building our shaded downstream artifacts.
+1 :green_heart:	javadoc	0m 13s	master passed
		_ Patch Compile Tests _
+1 :green_heart:	mvninstall	3m 8s	the patch passed
+1 :green_heart:	compile	0m 18s	the patch passed
+1 :green_heart:	javac	0m 18s	hbase-it generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 :green_heart:	shadedjars	4m 39s	patch has no errors when building our shaded downstream artifacts.
+1 :green_heart:	javadoc	0m 11s	the patch passed
		_ Other Tests _
+1 :green_heart:	unit	0m 42s	hbase-it in the patch passed.
		20m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/4662
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f03eaf1105e6 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / a3eeab8c56
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/1/testReport/
Max. process+thread count	588 (vs. ulimit of 30000)
modules	C: hbase-it U: hbase-it
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Comment
+0 :ok:	reexec	0m 38s	Docker mode activated.
		_ Prechecks _
+1 :green_heart:	dupname	0m 0s	No case conflicting files found.
+1 :green_heart:	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 :green_heart:	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 :green_heart:	mvninstall	2m 30s	master passed
+1 :green_heart:	compile	0m 26s	master passed
+1 :green_heart:	checkstyle	0m 10s	master passed
+1 :green_heart:	spotless	0m 44s	branch has no errors when running spotless:check.
+1 :green_heart:	spotbugs	0m 22s	master passed
		_ Patch Compile Tests _
+1 :green_heart:	mvninstall	2m 12s	the patch passed
+1 :green_heart:	compile	0m 24s	the patch passed
+1 :green_heart:	javac	0m 24s	hbase-it generated 0 new + 0 unchanged - 103 fixed = 0 total (was 103)
-0 :warning:	checkstyle	0m 8s	hbase-it: The patch generated 5 new + 34 unchanged - 5 fixed = 39 total (was 39)
+1 :green_heart:	whitespace	0m 0s	The patch has no whitespace issues.
+1 :green_heart:	hadoopcheck	12m 7s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 :green_heart:	spotless	0m 43s	patch has no errors when running spotless:check.
+1 :green_heart:	spotbugs	0m 26s	the patch passed
		_ Other Tests _
+1 :green_heart:	asflicense	0m 9s	The patch does not generate ASF License warnings.
		26m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/4662
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 780594bce52a 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / a3eeab8c56
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-it.txt
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-it U: hbase-it
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Comment
+0 :ok:	reexec	1m 27s	Docker mode activated.
-0 :warning:	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 :green_heart:	mvninstall	3m 14s	master passed
+1 :green_heart:	compile	0m 19s	master passed
+1 :green_heart:	shadedjars	4m 58s	branch has no errors when building our shaded downstream artifacts.
+1 :green_heart:	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+1 :green_heart:	mvninstall	3m 20s	the patch passed
+1 :green_heart:	compile	0m 27s	the patch passed
+1 :green_heart:	javac	0m 27s	hbase-it generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 :green_heart:	shadedjars	4m 15s	patch has no errors when building our shaded downstream artifacts.
+1 :green_heart:	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 :green_heart:	unit	0m 59s	hbase-it in the patch passed.
		20m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/4662
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a600968cad0b 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 486d19e99f
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/2/testReport/
Max. process+thread count	553 (vs. ulimit of 30000)
modules	C: hbase-it U: hbase-it
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Comment
+0 :ok:	reexec	1m 24s	Docker mode activated.
-0 :warning:	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 :green_heart:	mvninstall	3m 11s	master passed
+1 :green_heart:	compile	0m 28s	master passed
+1 :green_heart:	shadedjars	5m 20s	branch has no errors when building our shaded downstream artifacts.
+1 :green_heart:	javadoc	0m 16s	master passed
		_ Patch Compile Tests _
+1 :green_heart:	mvninstall	3m 31s	the patch passed
+1 :green_heart:	compile	0m 29s	the patch passed
+1 :green_heart:	javac	0m 29s	hbase-it generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 :green_heart:	shadedjars	4m 46s	patch has no errors when building our shaded downstream artifacts.
+1 :green_heart:	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 :green_heart:	unit	0m 51s	hbase-it in the patch passed.
		21m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/4662
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7ed4875a21cf 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 486d19e99f
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/2/testReport/
Max. process+thread count	574 (vs. ulimit of 30000)
modules	C: hbase-it U: hbase-it
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Comment
+0 :ok:	reexec	1m 13s	Docker mode activated.
		_ Prechecks _
+1 :green_heart:	dupname	0m 0s	No case conflicting files found.
+1 :green_heart:	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 :green_heart:	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 :green_heart:	mvninstall	3m 21s	master passed
+1 :green_heart:	compile	0m 29s	master passed
+1 :green_heart:	checkstyle	0m 12s	master passed
+1 :green_heart:	spotless	0m 52s	branch has no errors when running spotless:check.
+1 :green_heart:	spotbugs	0m 26s	master passed
		_ Patch Compile Tests _
+1 :green_heart:	mvninstall	2m 55s	the patch passed
+1 :green_heart:	compile	0m 26s	the patch passed
+1 :green_heart:	javac	0m 26s	hbase-it generated 0 new + 0 unchanged - 103 fixed = 0 total (was 103)
-0 :warning:	checkstyle	0m 12s	hbase-it: The patch generated 5 new + 34 unchanged - 5 fixed = 39 total (was 39)
+1 :green_heart:	whitespace	0m 0s	The patch has no whitespace issues.
+1 :green_heart:	hadoopcheck	13m 13s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 :green_heart:	spotless	0m 47s	patch has no errors when running spotless:check.
+1 :green_heart:	spotbugs	0m 28s	the patch passed
		_ Other Tests _
+1 :green_heart:	asflicense	0m 10s	The patch does not generate ASF License warnings.
		30m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/4662
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 4d2eaaf06b9a 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 486d19e99f
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-it.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-it U: hbase-it
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[taklwu]

should we merge this PR ? or do we need to fix those nits?

[Apache9]

Let me close this PR by a commit with the above fixes.