Duo Zhang
Duo Zhang
@vietj I've added some tests. PTAL? Thanks.
OK, check the code of VertxThreadFactory, the default implementation is not like JDK's DefaultThreadFactory... ``` default VertxThread newVertxThread(Runnable target, String name, boolean worker, long maxExecTime, TimeUnit maxExecTimeUnit) { return new...
OK. So here we plan to add a new option in VertxOptions? Then how could we pass this option to VertxThreadFactory? Add a new parameter called `daemon` for the newVertxThread...
Looking at the comment here https://github.com/eclipse-vertx/vert.x/blob/2439c849549b08a1e7ffee8f09eae886c9fe88f6/src/main/java/io/vertx/core/spi/VertxServiceProvider.java#L26 ``` /** * Entry point for loading Vert.x SPI implementations. * * @author Julien Viet */ public interface VertxServiceProvider { /** * Let the...
> I think it can be used for that purpose. OK, then I think we should change the above javadoc. And we also need to document out which fields of...
Mind explaining more about the algorithm here? I guess the problem here is that, when moving a region from rs A to rs B, the block cache on A is...
I do not fully understand why higher prefetched ratio leads to lower moving cost, if a region's hfiles have all been cached, after moving we need to fetched all the...
I also changed the script locally to use `agent-socket` instead of `agent-extra-socket` but probably this is just a different usage. I own the build machine so I can put the...
> > I also changed the script locally to use `agent-socket` instead of `agent-extra-socket` but probably this is just a different usage. > > I own the build machine so...
Any updates here? @ndimiduk > I suppose yes, we could add a configuration option, something like --gnupg-proveledged-socket, defaults to false. When false, it would forward the agent-extra-socket. When true, it...