Duo Zhang

Results 364 comments of Duo Zhang

Any progress here? @ndimiduk With HBASE-25983, we are ready to move the release process to jdk11. And for HBASE-27359, we also need to change the release scripts to generate different...

> I've not attempted release candidates anytime recently, so the status here is not changed. There's a couple reviewer questions about the wisdom of exposing the socket with elevated privileges....

What do you mean by 'standard socket'? I'm not an expert here, for me, I always need to change the extra-socket to socket when using the scripts locally on an...

> Yes, this is my point -- since we upgraded to this combination of gpg and maven-gpg-plugin, builds require use of the extra socket. This is why I think that...

> > I think we should add the check in AsyncBufferedMutator? BufferedMutator is just a delegation of AsyncBufferedMutator. > > @Apache9 sir. Thanks for your review. > > Although BufferedMutator...

The problem is about the API design. Increment and Append have return values but the current return values of BufferMutator methods do not return them...

> @Apache9 Sir. Do you still suggest adding check logic to AsyncBufferedMutatorImpl#mutate(List)? We'd better start a discssion thread on the dev list to discuss this.

> > > @Apache9 Sir. Do you still suggest adding check logic to AsyncBufferedMutatorImpl#mutate(List)? > > > > > > We'd better start a discssion thread on the dev list...

Mind explain a bit? What do you mean by opposite?