Duo Zhang
Duo Zhang
> Have you tried HBCK2 `addFsRegionsMissingInMeta` and `extraRegionsInMeta` functions? I believe those do the same as what you are proposing here, in other words, use hdfs info as the source...
@vietj FYI.
OK, so you prefer we add a ThreadOptions which only contains a daemon field in it, or we just add a daemon flag to VertxOptions directly? Thanks.
Got it. Let me update the PR.
I've updated the PR, PTAL. @vietj Thanks.
@vietj Any concerns here? Thanks.
Thanks @vietj for reivewing! I've updated the PR according to the review comment. Please take a look again. Thanks.
Ah, when trying to implement a UT, I found that we will not call threadFactory,init(VertxBuilder)... We will only call the init method on all VertxServiceProviders in initProviders method... That means,...
Thanks @vietj . The daemon option has already been fixed. The problem now is the current implementation does not work in real world, as the init method will never be...
@vietj Please take a look at the new approach? Just change the code where we used to force daemon to be false, to consider whether we want the thread to...