AndyZe

error: This package requires C++11

1

For me, this was simply fixed by adding: `add_compile_options(-std=c++11)` near the top of rgbdslam/CMakeLists.txt (I'm using Kinetic)

Spurious warning about C++ #include

1

I get a suggestion like this: ``` --- include/.../mtc_global_planner.h +++ include/.../mtc_global_planner.h.uncrustify ``` Which really does not make much sense. The error goes away when every other error is fixed. I'm...

Use angle between quaternions in OrientationGoal?

2

Currently the orientation goal looks like this: ``` virtual double evaluate(const GoalContext& context) const { // return getOrientation().distance2(context.getLinkFrame().getOrientation()); // return (getOrientation() - getOrientation().nearest(context.getLinkFrame().getOrientation())).length2(); return fmin((getOrientation() - context.getLinkFrame().getOrientation()).length2(), (getOrientation() + context.getLinkFrame().getOrientation()).length2());...

A warning would have helped us in debugging issue #139

Best approach to calibrate kinematic parameters

5

I'm interested in calibrating the kinematic parameters of a manipulator. The best way I can think of to do this is: - Checkerboard mounted on the arm - Camera mounted...

Depends on this `realtime_tools` PR: https://github.com/ros-controls/realtime_tools/pull/83

Dynamic memory allocation inside realtime functions / loops

6

I thought it was bad practice to declare a variable inside a realtime loop, but I see it a lot in this codebase. For example, [here](https://github.com/ros-controls/ros2_control/blob/6b495ef86889cbfdc1ee22ac77efa2ff589727ee/hardware_interface/src/actuator.cpp#L235) in actuator.cpp `write()`: ```...

Make several members of hw_interface atomic, for thread safety

5

Addresses #447. I look at this as cheap insurance because there's no downside to making these variables atomic AFAIK.

In the hardware_interface, some members should be atomic

2

It seems like `robot_program_running_` and `controller_reset_necessary_` should be std::atomic type for thread safety. I say this because it looks like there is potential to read the variables at the same...

Use the "group_name" for Bullet collision checks

6

Parse links in the CollisionRequest group_name and disable other links during the collision check. We are hoping to use this to speed up collision checking. I've tested this extensively with...