AndyZe

Results 260 comments of AndyZe

@livanov93 it would help reviewers a lot in the future if you put a nice, long description in the PR. Especially on a 1,000+ line PR like this. Why did...

I've spent some time debugging an issue with this plugin where the joints which are not actuated tend to droop with gravity over time. In other words, I'll command a...

How to actually link and execute the callbacks is a tough question. Perhaps the user could write their own composable ROS2 node that provides a service server by the name...

I think this would provide a lot of flexibility to do all kinds of things that are well-coordinated with a trajectory.

I think `bools` are almost a must-have, for buttons and grippers and pneumatic valves and things like that. `double` is nice for things like force/torque sensors. `uint` and `int` could...

The other way to handle this, I suppose, is just add ROS publishers/subscribers to the controllers. Since ROS2 messaging has real time capability now. It seems like this would duplicate...

I think what you propose sounds like a decent option. I believe the way it's implemented now is more efficient, though. Since we already have `delta_theta`, and dividing by a...

I'm guessing the yaml file you created isn't actually being used. Did you modify any of the launch files to load that yaml? Instead of creating a new yaml file,...

@caiobarrosv did you try `sudo apt install ros-melodic-velocity-controllers`? @gachiemchiep what happens if you do `rosservice call /controller_manager/list_controllers`?

We could probably take that out. I don't even remember what the exact issue was.