Hadrien Croubois
Hadrien Croubois
I'd like to add that it is not just about for loops. Some other pieces of code would benefit from that: In the case of [this](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/Checkpoints.sol#L39-L53), checking the bound would...
Thanks @CodeSandwich for this PR Note: We could use the same length-search pattern for the hex version.
> I would really appreciate if the log10 implementation was added as `Math.log10` so it could be used on its own. That also implies some more testing though, so I...
Hello @duckki The ERC20 standard doesn't prevent sending tokens to the contract itself, and there might be legitimate use-cases where users lock/stake their tokens that result in the contract transferring...
Hello @dmihal This is definitely on our roadmap! Since you are interested by this change, I have a few questions for you. - Do you inspect the content of revert...
Thank you @hrik2001 for this PR. We'll need tests and a changelog entry. Otherwize looks good
We can do an in place quick sort like [this](https://gist.github.com/Amxx/d3a99fcb79abbe3c76a2f2a5773b3815). One usecase we recently discovered is sorting leaves when doing a multi merkle proof verify
Rather than just discussing if that is a legitimate thing to do, what we should all discuss "what would the consequence be if someone does that". People do mistakes, and...
Also, the main motivation of this change is to save gas. We would need to measure that, but IMO the savings would be anecdotal
Having both a public and an internal is confusing to some. Having an internal and a private is to much IMO. A `if (x == address(0))` check doesn't include any...