openzeppelin-contracts icon indicating copy to clipboard operation
openzeppelin-contracts copied to clipboard

Published 20 hours ago • verified publisher icon OpenZeppelin

Added internal functions `_getInitializedVersion` and `_isInitializing` as required by #3584

Open hrik2001 opened this issue 2 years ago • 1 comments

Fixes #3584 @frangio, once you are okay with this. I would add the functions in InitializableMock.sol SingleInheritanceInitializableMock.sol MultipleInitializableMock.sol and write tests accordingly. Pardon me if I have messed up something since I am a novice.

PR Checklist

  • [x] Tests
  • [x] Documentation
  • [ ] Changelog entry

hrik2001 avatar Aug 04 '22 17:08 hrik2001

Thank you @hrik2001 for this PR.

We'll need tests and a changelog entry. Otherwize looks good

Amxx avatar Aug 08 '22 08:08 Amxx

@Amxx Hi! I have made changes accordingly (tests and changelog). Although some tests are failing. Is that worrying? Do let me know if I have to make more changes. Thank you!

hrik2001 avatar Aug 13 '22 07:08 hrik2001

@Amxx oops, my bad, looks like all the tests have passed and I might have looked at the old test results. Please let me know your review and sorry for sounding like a broken record 😅

hrik2001 avatar Aug 17 '22 13:08 hrik2001