Hadrien Croubois

Results 600 comments of Hadrien Croubois

@cruzdanilo > i had a big issue upgrading `ERC721`/`ERC721Enumerable` from v3 to v4 because the storage layout changed. fortunately Could you please open an issue about that, explaining what your...

Benchmark of the changes (running the transactions in `test/token/ERC721/ERC721.test.js`) ![Capture d’écran du 2022-07-06 10-03-21](https://user-images.githubusercontent.com/2432299/177501127-94b9cff7-ed6c-4a71-8526-740e79b8d130.png)

I understand that we want to experiment new minting mechanism. However, I believe that these minting mechanisms should remain ERC721 compliant, which means emitting a Transfer event for all the...

For reference: https://twitter.com/optimizoor/status/1544626818996613120?t=8tV84gD3blTSsxk14EotiQ TLDR: batch minting should be limited to "not to big batches" ... which means that the limit should never be reached, even minting 10**18 token each time

I believe once #3611 is merged, the requested changes will no longer be needed.

Hello @GrandSchtroumpf This would definitely be a nice change, but we need to check that all the documentation generation will support that.

I'd love to remove `See {IERC20-balanceOf}` in favor of `@inheritdoc IERC20` But from my early tests, https://github.com/OpenZeppelin/solidity-docgen doesn't support it :/

> Check the build-info with the compile output : `JSON.parse(output.contracts[sourceName][contractName].metadata).output.devdoc`. > The methods don't inherit the parent class. I just confirmed that. How are we supposed to get the inherited...

Hello @PavanAnanthSharma What are you trying to do here? - reverting with a hash defeat the purpose here. - is the pragma increase needed?

Hello @cygnusv, and thank you for raising that issue. I'll check what we can do, but please note that we want to move the `votingDelay` and `votingPeriod` to uint64