Hadrien Croubois

@ashwinYardi Cancel doesn't have other params. It just cancels the proposal that has a given ID. We could have required the cancel call to send all the details, hash them,...

One of the reasons for not introducing double hashing (in addition to the gas cost) is that it would be a breaking change that could affect upgradeable contracts that rely...

Indeed, I was considering adding a function that skips the length check when reading memory (or storage) arrays. For the gas optimization part, I believe that the arguments should be...

Hello @ToweringTopaz and thank you for your PR. IMO, this kind of optimization negatively affect readability and auditability of the code. I'm not sure how significant the gas savings are....

I ran both versions of the code with similar input. Going from solidity to assembly saves 122 gas. I tried setting the free memory ptr to a large value before...

> In addition to the savings on execution, this reduces deployment size by 360 bytes for a simple contract. That's a lot of bytecode, saving 77,000 gas on deployment. Were...

I think it's self explanatory. How would abi.encodePacked been used elsewhere affect the produced code. Can you measure that?

> If abi.encodePacked(bytes1,address,bytes32,bytes32) is used elsewhere that is deployment cost saving, right ? I guess its because the corresponding logic would be included anyway (like a private function).

I've added a "visual explanation" of how the assembly write to memory

Hello @philipSKYBIT If someone wanted to track the overall token supply, the best way would indeed be to have a `uint256 _totalSupplyAll` variable, that gets incremented in the `_beforeTokenTransfer` hook....