Hadrien Croubois

Results 626 comments of Hadrien Croubois

To iterate on @arr00's proposal, it is also possible to "just" do ```solidity contract PausableNoRevert is Pausable { function _pause() internal virtual override { if (!paused()) super._pause(); // else do...

I'm worried this would possibly be used by an attacker to extract value that is supposed to be burned. This change give access to all the rounding error that accumulate...

Hello @chiro-hiro ERC-6617 looks very similar to [AccessManagerLight](https://github.com/OpenZeppelin/openzeppelin-community-contracts/blob/master/contracts/access/manager/AccessManagerLight.sol) that we have in the community repository. This is a "light" version of the AccessManager contract that support 256 roles (including one...

Hello @adraffy. I'd be curious to understand in what cases this causes an issue. If you ask me, `IERC1155Receiver` having two different function is a bad design, and `onERC1155BatchReceived` should...

Hello @stuparm I'm curious what you think the extra parameters of reason should be, that is not already explicit enough in `EnforcedPause()`. Adding a string (or anything) has a cost....

Hello @saniksin `IERC721` is just an interface. It is common to declare interface using `external` functions and calldata. When you call a contract by casting an address using an interface...