Hadrien Croubois

Results 626 comments of Hadrien Croubois

Uses https://github.com/ethereum/solidity/issues/9117#issuecomment-1198003153 to skip checks

Would a multiple choice proposals be something like: - Option A: execute tx1 - Option B: execute tx2 - Option C: don't do anything ? It's interesting, but it creates...

Thank you @juniset for raising this issue. It is technically possible, and I would even say easy, to fix this issue for ERC20Permit. One should note that ERC20Votes (our implementation...

> Moreover, I see you have Votes implementation since 4.5, so hopefully, you are going to use this implementation in ERC20Votes. We would love to, but that would change the...

Hello @axic This is something I considered during the recent introduction of the `interfaces` folder. This was ruled out because ERC173 is not final, hence [its message asking about the...

There are two things: - ERC173 doesn't include the renounceOwnership function, and instead accepts transferring to 0. It be a breaking change on our end to comply with that. -...

There are some merge conflict that I can't solve since I don't have write access to Certora:master

Hello @ericnordelo, and thank you for this very interesting proposal. Block number is something we inherited from governor bravo compatibility, and IMO timestamp would be better. Your approach is really...

It is compatible with the current storage layout ... that we may break when we move to UDVT (which I should optimize that whenever we get to 5.0). Really this...