Andrew Kaster

Results 509 comments of Andrew Kaster

Oh I see. their code probably checks if `Performance.timing` exists, and then uses it if it does. ``` // https://w3c.github.io/navigation-timing/#extensions-to-the-performance-interface // Obsolete "Navigation Timing" extensions to the Performance interface [SameObject]...

@teaalltr can you retest this issue? It should :tm: have been fixed by https://github.com/LadybirdBrowser/ladybird/pull/4535

What you want to do is to edit the yaml, and push your changes to the default branch of your fork. You'll need to set the trigger rules to include...

Also seeing ubsan errors in the logs is a bit of a red flag. Are the UBSAN options env vars not being passed to the build step? Maybe we should...

Confirmed this works with llvm 20 installed manually. As the windows-2025 runners have. Due to path nonsense, I had to build like so though: `cmake --preset Windows_Sanitizer_CI -DCMAKE_C_COMPILER="C:\Users\Andrew\source\LLVM\bin\clang-cl.exe" -DCMAKE_CXX_COMPILER="C:\Users\Andrew\source\LLVM\bin\clang-cl.exe"`

It keeps happening :) those "not windows/only windows" conditions aren't for show, ya know ``` $ cmake --build --preset NotExist CMake Error: No such build preset in /home/andrew/ladybird-org/ladybird-browser: "NotExist" Available...

Also now the consistency of what is set in the base presets and what isn't is all messed up. I'll just push some fixes for my nitpicks :sweat_smile:

Can you take a look at this and apply it if it makes sense https://github.com/LadybirdBrowser/ladybird/commit/ac13f51d8bdbf902cda972c7f73656f95844b85f I don't like how the current state has inconsistent defaults for binaryDir, CMAKE_BUILD_TYPE and vcpkg...

> should Windows_CI now also inherit from vcpkg_ci? probably, but you can put that in your santiizer PR. I want to hurry up and merge this so I can rebase...

Also those are some interesting tests you posted. Might be good to get them into the repo. as RefTests, preferably, but could be one of the other two types as...