Andrew Kaster
Andrew Kaster
A user on discord was able to get the build working with none of the above steps, and only ```diff diff --git a/Meta/CMake/vcpkg/generate_vcpkg_toolchain_variables.cmake b/Meta/CMake/vcpkg/generate_vcpkg_toolchain_variables.cmake index a43a4493d6..caa2ee7a1e 100644 --- a/Meta/CMake/vcpkg/generate_vcpkg_toolchain_variables.cmake +++...
If you're really getting the specific error ``` execute_process failed command indexes: 1: "Abnormal exit with child return code: Segmentation fault" ``` when compiling specifically `skia` on Fedora 42, then...
Weird, something's up with compile checks in the sanitizer build.
conflicts, likely from PR I just merged
@mikeash this PR causes a build failure for me on linux on main due to a missing `#include ` in PrebuiltStringMap.h for the use of std::pair. Presumably due to recent...
First comment before review: Make sure your commit messages follow the guidelines. e.g. Imperative verbs, not past tense. `Do the thing` not `Did the thing`
The missing visit on document::m_fullscreen_element needs fixed: https://github.com/LadybirdBrowser/ladybird/actions/runs/14411993971/job/40447984611?pr=4330#step:11:1711 Make sure your IDE doesn't add `""` includes. `Files that #include a missing local file: Libraries/LibWeb/CSS/SelectorEngine.cpp Libraries/LibWeb/DOM/Element.cpp UI/Qt/BrowserWindow.cpp` And be sure to...
@galoisgroupcn refrain from advertising your business in our bug tracker. I doubt that such behavior is on the up and up with the GitHub TOS. > bulk distribution of promotions...
Could you split these two fixes into two separate commits (but still in the same PR)? It seems like Arche's comment describes better what the changes are doing, but I...
Is your homebrew configured to build for Rosetta2 by default or something? You should clear out any environment variables or other such config to get a consistent build environment. I...