Andrew Kaster

Results 509 comments of Andrew Kaster

I would check the permissions on Build/x86_64/_disk_image. if they are indeed messed up, chmod/chown-ing them to be accessible by your user should let it boot if you simply do `ninja...

I'mma just merge this. if that 0.0 thing is an issue I'm sure we'll find out eventually.

Looks like everyone's favorite gcc asan stack overflow flake https://github.com/LadybirdBrowser/ladybird/actions/runs/14847448002/job/41684463320?pr=4619#step:18:29 The ASAN output is dumped in a later step

It's a known flake, but I restarted the job (only contributors with write access can do so)

It would be a lot easier to debug and fix this issue if you could provide a short ~10 line HTML/CSS reproduction of each issue.

Linux is complaining about these: ``` /home/runner/work/ladybird/ladybird/Libraries/LibWeb/WebGL/OpenGLContext.cpp:86:119: error: unused parameter 'webgl_version' [-Werror,-Wunused-parameter] 86 | OwnPtr OpenGLContext::create(NonnullRefPtr skia_backend_context, WebGLVersion webgl_version) | ^ /home/runner/work/ladybird/ladybird/Libraries/LibWeb/WebGL/OpenGLContext.cpp:261:5: error: use of undeclared identifier 'glFlush' 261 |...

Er. well. maybe. Why does WebKit's gni-to-cmake python script use this tool? 😓 . it has some.. interesting ideas on distribution. The author has no interest in being a dependency...

@Lubrsi this should work now. Can you verify the commits `LibWeb/WebGL: Use WebGL version to determine ES version and extensions` and `LibWeb/WebGL: Specifically request ANGLE Metal backend on macOS`. Not...

Fwiw, in ladybird we do the following: - a WindowProxy is allocated for and associated with the new browsing context as part of the global object customization steps in step...