Andrew Kaster

Results 509 comments of Andrew Kaster

> In addition to these changes, building against system libraries required me to compile skia with "extra_cflags_cc=[\"-DSKCMS_API=[[gnu::visibility(\\\"default\\\")]]\"]" as a gn arg (see also https://github.com/LadybirdBrowser/ladybird/commit/4d7b7178f9d50fff97101ea18277ebc9b60e2c7c) This should be patched in skia...

Also I haven't checked in a while, but does the "vcpkg cache" feature properly use clang-20? or does launching the container and running ./Meta/ladybird.py run do a full vcpkg rebuild?...

@xet7 that would be great! We currently implement the dnd parts of the HTML spec in Libraries/LibWeb/Page/DragAndDropEventHandler.cpp That's where things like https://html.spec.whatwg.org/multipage/dnd.html#fire-a-dnd-event and https://html.spec.whatwg.org/multipage/dnd.html#drag-and-drop-processing-model are currently partially implemented. It looks...

Quick question on this: does adding `qt` to vcpkg.json solve the issue? It will also result in building qt6 from source to do this, however.

..huh? what dependency of ours is pulling in libvpx via a `3rdparty/chromium` path?

Dang it. After I tried to chunk them properly too

n.b.: https://forums.swift.org/t/ladybird-gc-and-imported-class-hierarchies/78790

Unfortunately I cannot enable library evolution: I get heaps of `cannot use struct 'Foo' here; C++ types from imported module '__ObjC' do not support library evolution` errors. So, I won't...

Enabling that almost works. It seems like there is still an issue with a nested imported type from another module? From what I can gather, it looks like me adding...