Andrew Kaster

Results 509 comments of Andrew Kaster

I think it would be useful to create a test class that measures the number of times an instance is swapped or compared using the comparator. Doing so would let...

> When I split the PR, what happens to review comments on files that no longer exist in the branch? Do they get lost? You should create a different git...

Looks like it's crashing trying to draw an SVG Circle element. Is there a way to isolate the specific SVG into a smaller test case?

Normally just opening a PR is the way to go, but you're free to mention that you're working on an issue. Just know that that's more of a courtesy, and...

> If everything ends up in the place that's specified, leaving nothing in the original place, does that work? As I hinted at in https://github.com/swiftlang/swiftly/issues/277, I would prefer if I...

Chiming in to say that this feature would be very useful for testing after a team pushes a fix to swift/main for bugs I've reported, so that I don't have...

Really? That's strange. I was expecting there to be an environment variable to control where toolchains are installed no matter what platform I'm installing on, similar to [`RUSTUP_HOME` ](https://rust-lang.github.io/rustup/installation/index.html#choosing-where-to-install)

> Since swiftly is a user-level toolchain manager, it installs them in the current user's home directory volume, so they go under the same location, but relative to the user's...

@teaalltr what user agent did you spoof as? It loads fine for me on master but gives me a "I hate your user agent" page:

> . It breaks when trying to access PerformanceTiming::navigation_start() from inside a Worker That should be impossible. it's only exposed on Window ``` // https://w3c.github.io/navigation-timing/#dom-performancetiming [Exposed=Window] interface PerformanceTiming { ```