Andrew Kaster

Results 509 comments of Andrew Kaster

Another alternative would be to introduce a keyword exactly like C++'s ``static`` (private? local?) to explicitly mark functions as module-private, and sidestep the extra implications of "export". Then that leaves...

I got those scalable_malloc errors on SerenityOS untill I added this patch: https://github.com/SerenityOS/serenity/blob/master/Ports/mold/patches/0003-Tell-TBB-that-SerenityOS-does-not-support-weak-symbo.patch Defining away weak symbol usage in tbb made the linker stop putting unresolved weak symbol references to...

Most raw `__attribute__` have (should be?) replaced with the macros from AK/Platform.h. Doesn't look like there's one for NORETURN

The reason windows based compilers complain about this is that in the windows C library, `abort()` is not [[no return]] like the C++ spec says it should be. An escape...

> jakt currently has no installer I added this yesterday :) https://github.com/SerenityOS/jakt/blob/main/documentation/cmake-bootstrap.md

These updates seem all right and not super invasive or a burden for maintenance. Nice work! I left a few comments on future fixmes.

I believe our locale.h *is* compliant -- the C library only accepts the C locale. The issue with ctype relates to us pretending to be newlib but not having the...

Turns out plenty of systems tell libc++ to provide its own "Rune table" ... so us doing so as well isn't that big a deal.

We should update the CMake patches to reflect the fact that LibDL is now an ld-script stub like Musl's by removing the LibDL lib variable from the Platform files.