Andrew Kaster

patching curl for this seems awkward from a distribution point of view. For example, your quirk patch is not included in the flatpak build. third-party packaging from e.g AUR and...

Agree with Ali. To pull this in, I'd hope for 1) a separate commit pulling in libcurl as-is from vcpkg, to better determine what is "upstream port" and what is...

I'd like to see `Screenshot` rather than `Take Screenshot` as the app name. As Sam said, we can refactor to not spawn the command line process later. Perhaps a FIXME?

First thought: What about a `Skipped_` section in the ini file instead of making weird looking `relative-path=list,of,strings` key-value pairs?

If we did that the logic would be like ``` for platform in my_platform_list: if group = config.group(`Skipped_${platform}`): for key in group: list_of_skipped_tests.append(key) ``` Which seems a bit simpler than...

:man_shrugging: ini is a very restrictive format. if we want more interesting things to happen, loading a JSON file with AK::JsonValue::from_string wouldn't be the worst thing in the world. Lemme...

``` git clone --depth 1 -b d6995a0cf3cafda5e9e52749fad075dd62bfd90c https://github.com/microsoft/vcpkg.git Cloning into 'vcpkg'... warning: Could not find remote branch d6995a0cf3cafda5e9e52749fad075dd62bfd90c to clone. fatal: Remote branch d6995a0cf3cafda5e9e52749fad075dd62bfd90c not found in upstream origin ```...

This discrepancy was previously discussed in #3998 and https://github.com/LadybirdBrowser/ladybird/issues/3998#issuecomment-2736495122 Are these the only obvious print difference between our REPL and those of other engines? iirc our printing of deeply nested...

Hm, yes this is a known requirement. We should simply add it to the build documentation that this needs exported globally in your shellenv. It's already been added to the...

- What does your configure log in the terminal say about the tests related to `Performing Test COMPILER_HAS_HIDDEN_VISIBILITY`? - What does your Build/release/CMakeFiles/CMakeConfigureLog.yaml say about those checks? If any of...