Andrew Kaster
Andrew Kaster
This potentially looks like an llvm 19 issue with that particular library. A way to debug would be to go to a new directory and manually vcpkg install libyuv for...
That is to say, we should try to reduce the issue and report it to vcpkg to sort out. Or to homebrew. I suspect some flag wrangling needs to happen...
I see! that's good. In that case, we should submit that patch to vcpkg if it's not already there, and we can add that patch locally until we update vcpkg...
> does this solution implies sockets support sending fds in empty messages? It certainly seems that that's the case. I tested this with the MAX_TRANSFER_FDS set as low as 8...
Ha! I do happen to have most of these changes either in my branch or locally. Major difference being renaming LibProtocol to LibRequests (which is the change I actually made)...
Thanks for the docs update, but I think you've misunderstood the referenced issue. `VCPKG_FORCE_SYSTEM_BINARIES` is not required on macOS, even though that's where you've updated the docs. A complete fix...
Only thing that comes to mind is perhaps the warnings aren't generated by clangd? If there's a separate clang-tidy or related c++ language server, it might not pick up all...
If folks can verify that the nixpkgs build from [ladybird-0-unstable-2024-07-11](https://github.com/NixOS/nixpkgs/pull/326493) works for them locally, we can close this issue with a documentation update explaining how to do that in BuildInstructionsLadybird.md
I think the last thing needed to resolve this is for a PR to remove the local nix env derivation, and update the nix build instructions documentation to do something...
@qm3ster bad analysis skia should be built by the nix shell, is that not the case? I would expect that this statement: https://github.com/LadybirdBrowser/ladybird/blob/05351dfe45e3b7eb4c4d0a0ee69ebaf185571bdc/shell.nix#L6-L16 Instructs nix to gather all the inputs...