Andrew Kaster

Results 509 comments of Andrew Kaster

Possibly-relevant original commits: Switch from select to poll: https://github.com/SerenityOS/serenity/commit/6836091a215229a6fdd44559bd22b5dce7345f66 (https://github.com/SerenityOS/serenity/pull/23046) Timer refactor: https://github.com/SerenityOS/serenity/commit/120d6b2f21be12e3a8ba5e6728493eddd80ac8b5 (https://github.com/SerenityOS/serenity/pull/23149)

> The core of the problem is that Core::EventLoop::pump is called again (from spin_until) after timer fired but before its handler is executed. This ... feels unfortunate. Calling spin_until from...

> But again, it is more a matter of preference. If maintainers make me change it I'll change it, but for now I want to keep lowercase. Consider this a...

> Can we close this issue? No, because HTTP/3 support is still experimental in curl

Eh. I'd rather the Android port be in a bit more usable state than it currently is before declaring this issue closed. For example, you can't scroll the viewport, there's...

> Can you elaborate on why you need to do this? :) When working solely with Xcode.app (or probably CommandLineTools too) toolchains, a CMake project can get away with this:...

So I guess this is really more of a "everything is different depending on platform" issue looking at things more closely... Xcode.app (16.2 16C5032a): - libTesting.dylib lives in `/Applications/Xcode.app/Contents/Developer/Platform/MacOSX.platform/Developer/Library/Frameworks/Testing.framework` -...

I made a patch for ladybird to fix this, as we don't have the `metadata/update-properties.json` file locked down yet. (or... even generated, or know how to generate it or ...)...

Have we tried running this script with system Python on macOS? I think I'm always on python 3.12+ these days

Oh forgot to mention, big 👍 for the ctrl+c behavior change. Those useless KeyboardInterrupt traces bothered me too, but not enough to fix it.