ladybird icon indicating copy to clipboard operation
ladybird copied to clipboard

Update BuildInstructionsLadybird.md

Open oemmerson opened this issue 11 months ago • 4 comments

Missing env param when building on Macos. See https://github.com/LadybirdBrowser/ladybird/issues/2417 for more details.

oemmerson avatar May 01 '25 20:05 oemmerson

Hello!

One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why. Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

ladybird-bot avatar May 01 '25 20:05 ladybird-bot

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar May 23 '25 02:05 github-actions[bot]

Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest master.

github-actions[bot] avatar May 29 '25 20:05 github-actions[bot]

Thanks for the docs update, but I think you've misunderstood the referenced issue. VCPKG_FORCE_SYSTEM_BINARIES is not required on macOS, even though that's where you've updated the docs.

A complete fix for 2417 would document the Additional requirements for Asahi Linux in a reasonable section of either BuildInstructionsLadybird.md or AdvancedBuildInstructions.md

ADKaster avatar May 30 '25 21:05 ADKaster

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Jun 21 '25 02:06 github-actions[bot]

This pull request has been closed because it has not had recent activity. Feel free to open a new pull request if you wish to still contribute these changes. Thank you for your contributions!

github-actions[bot] avatar Jun 29 '25 02:06 github-actions[bot]