Andrew Kaster
Andrew Kaster
This isn't quite right either. It's still dependent on $PWD. The proper fix is probably something more like ``` #!/usr/bin/env bash set -e DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &&...
Thanks for the PR! I tried to tackle this issue more fully in https://github.com/LadybirdBrowser/ladybird/pull/4291, where the idea is to create a FontConfigFontProvider that will lazily cache the fonts needed by...
> indeed! this pr does not address that issue. if you don't mind sharing - what was the challenge for finalizing the changes that you were making / what were...
We're likely going to leak allll sorts of things unless we take extra care to do 'full' GC collections b/w tests or destroy the VM on exit.
For some actual actionable feedback, I think that we should absolutely have this, and that it failing in the sanitizer step is appropriate. A blurb of text to say "This...
... and an issue to remind us to look into the detected leaks. I suspect (like I mentioned above) that it's related to not collecting the GC heap, but we...
@Pavan3861 Please don't clutter our issue tracker with AI slop
The context here is https://github.com/LadybirdBrowser/ladybird/issues/1840
As mentioned on another PR, please make any and all added header files follow the project conventions for naming
cc @DanShaders , is this an artifact of your Timer refactor from a while back? Context from the fix in 3188 ``` The spin_until([&]{return completed_tasks == total_tasks;}) in TraversableNavigable::check_if_unloading_is_canceled spins...