Andrew Kaster

Results 509 comments of Andrew Kaster

@bgianfo @networkException halp, running `yarn update discord.js` (to get the latest nickname resolution changes from ~last year) is requesting node 18? How do I safely update discord.js and/or the CI/production...

>it should already be on 20.x Not according to this commit. https://github.com/SerenityOS/discord-bot/commit/3c5e0ab210da30efce3dc11095bd15358c7c5daa Looks like we pinned it to 18.17.1 due to some node-gyp error in the heroku install or something?

The ports for Python3 and Ruby also have this requirement, but we have scripts in Toolchain to build the host version from source. Requiring it for a utility like file...

I'll drop the CI commit until we can have the warnings enforced :)

> Is the issues :ciflakes:? 🤔 I don't think we can add these emoji until we start downloading `https://www.unicode.org/Public/emoji/16.0/emoji-test.txt` Currently we still only download the file for version 15.1, same...

That's quite unfortunate that we can't calculate "how much stack is left" on musl the same way we do pretty much every other C library (except Wasm32 on emscripten). Looking...

Wait I've got it. On musl, we should change LibMain to just call serenity_main in a secondary thread and then block the main thread waiting for it to exit! Genius.

Well... pulling from getrlimit(RLIMIT_STACK) and comparing that to some magic "origin" value doesn't seem like the *worst* idea. The commit message responsible for that part of wtf mentions that they...

A patch to add a little extra spice to our ifdef soup in StackInfo.cpp along the lines of ``` #endif // big ifdef chain #if defined(AK_OS_LINUX) && !defined(AK_OS_ANDROID) && !defined(AK_LIBC_GLIBC)...

re: request server, try this: [`9d3edc3` (#24273)](https://github.com/SerenityOS/serenity/pull/24273/commits/9d3edc31aac0f9fe72fb17be91a1cc8333fb22b8)