Elias Rohrer

Results 301 comments of Elias Rohrer

Would probably make sense to do this as part of / after https://github.com/lightningdevkit/rust-lightning/pull/3201 ? (cc @optout21)

> The 90 days sometimes really hurts me as I need to figure out how to handle these cases, but ... personally I like 90 days. That is three months...

Seems this isn't properly rebased, hence CI is failing?

> > Seems this isn't properly rebased, hence CI is failing? > > I think #3626 will fix this. No, it fails with: ``` src/ln/our_peer_storage.rs - ln::our_peer_storage::OurPeerStorage (line 48) stdout...

This unfortunately needs a rebase now.

@adi2011 #3784 has landed, please rebase to fix CI!

> Also, if your goal is just to have a json version of some structs, maybe we should only implement Serialize, not De? Mh, but if you're able to serialize...

This needs a rebase by now. @amackillop still interested in working on this?

Seems CI is failing unfortunately.

> Yea, I think we can extend the new `BackgroundProcessorBuilder` or provide a new builder for the async variant. But extending the new builder might be the better approach as...