Elias Rohrer
Elias Rohrer
FWIW, we saw similar flaky behavior in LDK Node's integration tests. I might be wrong, but I suspect this could be a race with `ChannelMonitor` persistence that might have been...
> * I want to be able to add new, default-able fields in persisted data as non-breaking changes so we don't need to do a new major release every time...
> Same here, a reference implementation section would be useful. Hmm, good point in this case, as there is no implementation of this protocol as of today. We plan to...
Rebased after https://github.com/lightning/blips/pull/55 landed.
> Needs a rebase and this should be good to go? Ah, I though we'd wanted to wait with this until a reference implementation is available?
> Good point, if there is one that is being worked on then it's better to wait! Yes, there is work-in-progress, will give an update here once that has been...
I now updated this PR to: a) make it clear HTTPS is mandatory b) drop the custom replay protection, as we assume network-level replay attacks are mitigated by using HTTPS...
> > I also want to note that the reference implementation has been merged on the LDK side (see [lightningdevkit/rust-lightning#3662](https://github.com/lightningdevkit/rust-lightning/pull/3662)), so we should be able to proceed with this PR...
> LGTM: note that the README at https://github.com/lightningdevkit/rust-lightning/tree/main/lightning-liquidity doesn't mention that LSPS5 is implemented, you may want to update that? Ah, thanks for pointing that out. (cc @martinsaposnic, mind including...
Discussed this offline: we'll add additional arguments for channel ID and 'transaction label' to broadcaster interface that allows the implementer to intercept what the 'type' (funding, closing, splice in/out, bump)...