Elias Rohrer

Results 301 comments of Elias Rohrer

This needs another rebase unfortunately. Also, good opportunity to check whether the `electrum-client` release really fixed our doc builds.

Feel free to rebase once more as we just landed https://github.com/lightningdevkit/rust-lightning/pull/4206 to check for breakages.

> This is a huge PR, but it wasn’t obvious to me how to split it in a way that would still make sense (I did split it into small...

Btw, I'm not sure if you're familiar with the previous attempt of implementing LSPS5: https://github.com/lightningdevkit/rust-lightning/pull/3499 Given this is a clean slate, not sure how much there is to learn, but...

> FYI I fixed the Rust 1.63.0 build failures by downgrading the url crate to 1.7.2 in [this commit](https://github.com/lightningdevkit/rust-lightning/pull/3662/commits/fdb5db49ab219f39fe1d57c5bac34283a30c5670). > > I'm not thrilled about using such an old version...

> This should be ready to review again Cool, thank you! I think this is ready for more eyes now! Given the size of this PR, I'll let the bot...

> I do kinda wonder if this is worth it? What is the practical user impact of not checking for expiry? Presumably the LSP will simply fail the attempt to...

> I don't see why that's a concern. If someone registers a non-TLS webhook or one with weak authentication, that sounds like a them issue, but more generally, the handling...

> Fair. I understood that the spec was finished Yeah, it was finalized for now, but we're currently the only ones implementing bLIP-55/LSPS5, so we can make additional adjustments at...

> I'd say let's keep this open and see how other people would give input. Well, I commented on #833 and opened #1411 back then before giving up on the...