Elias Rohrer

Results 301 comments of Elias Rohrer

I think introducing this approach here might be a good first step, which at least would allow us to mitigate the issue by downloading the binary ourselves in CI. However,...

Sorry for the delay here. I'm experimenting with the optional dependency, not entirely sure it will work as expected, since it's a bit unclear to me how to still maintain...

@RCasatta It seems by now this crate requires ~1.67 or so just due to some downstream dependency (I think `zstd-sys`). It would be great if we could introduce an MSRV...

Mh, looking at this again since we're still regularly see failing tests like: ``` thread 'test_esplora_syncs' panicked at 'called `Result::unwrap()` on an `Err` value: JsonRpc(Rpc(RpcError { code: -4, message: "Wallet...

> Any idea to make the cleanup code more robust? > > tempfile crate should take care of creating a unique data dir and clean the dir once the ref...

Can second the wallet flakiness, we're seeing the same issue pop up in CI (cf https://github.com/lightningdevkit/rust-lightning/pull/2098#issuecomment-1466981268): ``` ---- test_esplora_syncs stdout ---- thread 'test_esplora_syncs' panicked at 'called `Result::unwrap()` on an `Err`...

FYI, since I needed it for LDK's electrum integration, I added a utility to validate merkle proofs to `rust-electrum-client` a while back: https://github.com/bitcoindevkit/rust-electrum-client/pull/122 Just mentioning it as they could potentially...

What's the idea around `electrsd` after this crate now has been moved to `rust-bitcoin` and, IIUC, will be deprecated in favor of `rust-bitcoind-json-rpc/regtest`? Will there be further work on `electrsd`,...

Any reason not to directly bump to 0.32, which will be ecosystem standard for a while, according to the 'Nashville agreement'?

> Merging this into #3106 as per feedback. Should this PR get closed then?