rust-lightning icon indicating copy to clipboard operation
rust-lightning copied to clipboard

Re-export bech32

Open benthecarman opened this issue 1 year ago • 3 comments

In the upgrade to rust-bitcoin 0.31, bech32 is no longer re-exported. This is needed for the u5 type by the NodeSigner for the sign_invoice function. This just re-exports the bech32 crate to handle this.

benthecarman avatar Jul 30 '24 17:07 benthecarman

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.70%. Comparing base (a76ec06) to head (3beb16c). Report is 1064 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3208      +/-   ##
==========================================
- Coverage   89.80%   89.70%   -0.11%     
==========================================
  Files         122      122              
  Lines      101621   101791     +170     
  Branches   101621   101791     +170     
==========================================
+ Hits        91261    91311      +50     
- Misses       7674     7782     +108     
- Partials     2686     2698      +12     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 30 '24 17:07 codecov[bot]

Would probably make sense to do this as part of / after https://github.com/lightningdevkit/rust-lightning/pull/3201 ? (cc @optout21)

tnull avatar Jul 30 '24 18:07 tnull

Yea, we'll see what happens in that PR first, then we can revisit this I think. I kinda hate the re-exporting thing, but maybe others have different opinions.

TheBlueMatt avatar Aug 05 '24 16:08 TheBlueMatt

Closing as abandoned. We shouldn't need this post-0.32.

TheBlueMatt avatar Feb 09 '25 22:02 TheBlueMatt