Elias Rohrer
Elias Rohrer
> Hmm, node_announcements shouldnt ever be sent by mostly-offline nodes, however? > They're only relevant for routing nodes, so rebroadcasting on a timer once an hour should more than suffice....
> In that case the counterparty should get the node info when they do regular gossip sync from us, rather than via our hourly (or whatever) broadcast timer. Yes I...
> Wait, so we're talking about a setup where we have one public, large-ish routing node, with open channels and multiple peers that's online 24/7, and an LDK Node node...
> Right, for IPs specifically we're looking at including hosts in the RGS data. Aliases would also be a nice-to-have as Wallet will want to present human-readable names. Currently, they'd...
> Hmm, I'm vaguely surprised a mobile wallet would care what a node's alias is? Should they really be displaying that vs picking a node they know? I think it...
Assigning myself for now, hope to pick this up soonish.
> I guess we should add a trivial channel config update parameter to the channel acceptance method? Yeah, that or breaking up the current config object into parts that are...
Isn't this more or less redundant since we already log `next_outbound_htlc_limit_msat` for any first-hops we ignore?: https://github.com/lightningdevkit/rust-lightning/blob/f5ee8c23a1a52bc51c00eb8a62b0b5226acee80b/lightning/src/routing/router.rs#L2178-L2183
@ConorOkus I don't think this is completed, the occurances of `KeysInterface` the above comment mentions are still present in current main? For example: https://github.com/lightningdevkit/lightningdevkit.org/blob/300e80131b5bdad894b003847affc0af86e1651b/docs/key_management.md?plain=1#L189 and the `.as_KeysInterface()` occurrences in the...
> https://calendar.google.com/calendar/u/0/r?cid=Y19lNmZ2NnZsc2hicG9vYjJtbWJ2Ymxra29qNEBncm91cC5jYWxlbmRhci5nb29nbGUuY29t In https://github.com/lightningdevkit/rust-lightning/pull/1637 I decided to go with the 'embedded' link, as this one doesn't seem accessible without being logged in to Google.