rust-lightning icon indicating copy to clipboard operation
rust-lightning copied to clipboard

Add functions to handle ClaimInfoRequest and PersistClaimInfo events.

Open G8XSU opened this issue 1 year ago • 1 comments

Based on #3067

  • Add functions to handle ClaimInfoRequest and PersistClaimInfo events.

As part of #3049

G8XSU avatar Aug 01 '24 17:08 G8XSU

Codecov Report

Attention: Patch coverage is 0% with 63 lines in your changes missing coverage. Please review.

Project coverage is 89.68%. Comparing base (50d21b7) to head (c281700). Report is 357 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/chain/channelmonitor.rs 0.00% 28 Missing :warning:
lightning/src/events/mod.rs 0.00% 19 Missing :warning:
lightning/src/chain/chainmonitor.rs 0.00% 16 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3217      +/-   ##
==========================================
- Coverage   89.75%   89.68%   -0.08%     
==========================================
  Files         122      122              
  Lines      101791   101854      +63     
  Branches   101791   101854      +63     
==========================================
- Hits        91367    91350      -17     
- Misses       7743     7817      +74     
- Partials     2681     2687       +6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 01 '24 18:08 codecov[bot]

Merging this into #3106 as per feedback. Addressed most of the comments here, some might be unanswered. Will move some questions to 3106, and close the rest here.

G8XSU avatar Aug 28 '24 20:08 G8XSU

Merging this into #3106 as per feedback.

Should this PR get closed then?

tnull avatar Aug 29 '24 07:08 tnull

Yes, i will close this after answering some comments here.

G8XSU avatar Aug 29 '24 07:08 G8XSU