Shashwat Vangani

Updated from [pr3246.23](https://github.com/shaavan/rust-lightning/commits/pr3246.23) to [pr3246.24](https://github.com/shaavan/rust-lightning/commits/pr3246.24) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3246.23..pr3246.24)): Addressed @jkczyz comments Changes: 1. Addressed documentation fixup, and test improvements.

Hey @TheBlueMatt @tnull, A gentle ping! Would love to get your feedback or approach ACK before moving forward with testing and applying a similar approach on the BOLT11 side. Thanks...

Updated from [pr3342.01](https://github.com/shaavan/rust-lightning/commits/pr3342.01) to [pr3342.02](https://github.com/shaavan/rust-lightning/commits/pr3342.02) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3342.01..pr3342.02)): Changes: 1. Rebase on main

Updated from [pr3342.02](https://github.com/shaavan/rust-lightning/commits/pr3342.02) to [pr3342.03](https://github.com/shaavan/rust-lightning/commits/pr3342.03) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3342.02..pr3342.03)): Addressed @vincenzopalazzo, @jkczyz, @TheBlueMatt comments Changes: 1. Renamed `ManualRoutingParameters` -> `RouteParametersOverride` 2. Reintroduce the `max_total_routing_fee_msat` in `AwaitingInvoice` to support downgrading. 3. Update API, so...

Updated from [pr3342.03](https://github.com/shaavan/rust-lightning/commits/pr3342.03) to [pr3342.04](https://github.com/shaavan/rust-lightning/commits/pr3342.04) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3342.03..pr3342.04)): Addressed @TheBlueMatt’s comments: Changes: ### Update Role of RouteParamsOverride: 1. Instead of presenting this new struct as just overriding the PaymentParams, it is now...

@TheBlueMatt > Looks like most of my previous comments went unaddressed? Just checking cause I interpreted your comment as you addressing them. Hey Matt, I’m really sorry for missing your...

Updated from [pr3342.04](https://github.com/shaavan/rust-lightning/commits/pr3342.04) to [pr3342.05](https://github.com/shaavan/rust-lightning/commits/pr3342.05) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3342.04..pr3342.05)): Changes: 1. Rebase on main. Rest no changes.

Updated from [pr3342.05](https://github.com/shaavan/rust-lightning/commits/pr3342.05) to [pr3342.06](https://github.com/shaavan/rust-lightning/commits/pr3342.06) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3342.05..pr3342.06)): Addressed @jkczyz, @TheBlueMatt comments Changes: 1. Fix the comment regarding supporting standard behaviour during upgrade. 2. Set the max_total_routing_fee_msat along with route_params config to...

> Okay, we probably shouldn't have held this up on https://github.com/lightningdevkit/rust-lightning/pull/3378 now that it took way too long to land, but it did finally land, care to rebase on that?...

Updated from [pr3342.06](https://github.com/shaavan/rust-lightning/commits/pr3342.06) to [pr3342.07](https://github.com/shaavan/rust-lightning/commits/pr3342.07) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3342.06..pr3342.07)): Addressed @TheBlueMatt comments: Changes: 1. Rebase on main.