Sam Clegg comments

Results 1043 comments of


                                            Sam Clegg

trafficstars

EMSCRIPTEN_VERSION macro in JS libraries

I opened https://github.com/emscripten-core/emscripten/issues/22510, but I'm also fine with adding a new builtin macro if you don't want to block on that.

Code size regressions with WASI, environ, libc/filesystem

One way to figure out why a given function is included would be to use `-Wl,--trace-symbol`. For example `-Wl,--trace-symbol=raise` might help understand any raise is being included. That does seem...

Fix concatenating --pre-js files even if one of the input files has a // comment on the last line

> > Looks like we lost the actual fix someshow? > > It looks like the debug comments that have been added in main have a side-effect of applying the...

emscripten_request_animation_frame_loop(), emscripten_set_main_loop(), emscripten_set_timeout() etc. are not compatible with JSPI

`makeSuspendingDynCall`?

Enabling -sSOCKET_DEBUG= spams console with all kinds of debugging unrelated to sockets debugging.

I've found it useful to enable `RUNTIME_DEBUG` automatically whenever I enable any of the other kinds of debugging. The idea is that `RUNTIME_DEBUG` includes core stuff that its always useful...

discussion - feasibility to integrate `https://wicg.github.io/file-system-access/`

@tlively is this the same thing you are working on with wasmfs+opfs?

Command line length limits are easily exceeded on Windows

So frustrating...

Use simple import.meta.url for worker creation

> Looking at the test failures in `test-other`, I think it needs to be `new Worker(new URL(import.meta.url))`, at least on Node.js. > > ``` > TypeError [ERR_WORKER_PATH]: The worker script...

Fix retrieval of mounted directory names

Can you add a test for this? That might also help me understand the problem we are solving here.

Fix retrieval of mounted directory names

I recently updated `test_unistd_unlink` in `test_core.py` such this it skips under wasmfs due to this bug.. can you remove the `skipTest` there as part of this PR?