Sam Clegg

Results 1109 comments of Sam Clegg
trafficstars

It looks like the old version of this header (which was removed in #7924) did contain this function but when it was re-introduced in #11243 that function was not included....

I normally do all my work over ssh and then point my browser at the IP of the my server.. so I guess I will always be adding `--hostname 0.0.0.0`....

> > so I guess I will always be adding `--hostname 0.0.0.0`. > > Hmm hmm.. yeah, I can see that this can be tedious. > > Although emrun already...

Making them configurable seems like maybe unnecessary. Putting them in a header seems pretty reasonable. Maybe just in the existing header for the binary file stuff.

Hopefully only the parsers / validators need to enforce these limits. The interpreter can assume all its inputs have been validated. There may be some exceptions but I can't think...

So are you proposing landing this without tests? Or is this still a draft PR with more changes coming maybe?

I suppose I'm ok with landing this as an internal refactor. Hopefully any followups can have tests?

Adding @aheejin too

I think you want to add `// clang-format off`` / `// clang-format on` around those switch statements.

Do you want to rebase this change and we can see how much of it remains after the split out changes.