Sam Clegg

Results 1050 comments of Sam Clegg
trafficstars

> Thanks but I'm on windows, without LLVM or clang. 😅 `emsdk install tot` takes care of installing all that for you at the correct version.

I'm happy to do that rebase for you if install emsdk is too much? (But how are you running emscripten then?

Actually I was chatting with @brendandahl and we think maybe the DefinitelyTyped definition is wrong here. We really want something that is a object/dictionary that matches `INCOMING_MODULE_JS_API`.

We can maybe land this for now then move away from it. BTW, are using using the generated types in combination with `DefinitelyTyped` somehow? Should we try to update to...

@brendandahl should file a bug to have https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/emscripten/index.d.ts removed? It seems like emscripten-generated types via `--emit-tsc` are always going to better, and anything checked into DefinitelyTyped likely never going to...

> Turned the libembind into a MTLibrary. The question whether it is acceptable remains. Seems like a reasonable solution yes. Its a pretty small library anyway.

> Don't we need an opt-out mechanism to be able to land tests that node/V8 doesn't currently pass? Yes, good point. The comment I'm replacing here seems to suggest that...

It seems like `ref_null.wast` is failing under node, @backes do you know if this is know failure of current v8 against the wasm-3.0 spec tests?

Apparently there is a fix in v8 that landed just this morning that might be fix this, so I guess we are already running into the issue of needing to...