Sam Clegg

Results 1093 comments of Sam Clegg
trafficstars

The reason I suggest the split is that part of this change (adding a wasi build) is completely uncontroversial. Its the adding of distro-specific files in the top level directory...

> > Its the adding of distro-specific files in the top level directory that I think is a somewhat controversial. Just like we would probably wouldn't want debian or redhat...

This dicussion is why I suggested to split the wasi-building part of the PR out, so that we could discuss that separably from the wapm metadata. I would rather see...

Would you mind splitting this PR so we can land the wasi builder script on its own?

Sorry for the delay responding here. I'm afraid I haven't had a change to take a deep look at wasienv. I think such tool could be a useful part of...

@alexcrichton is this something wasm-pack can do or should we try to do it here in the binaryen CI? Do you want to have go at this? Even if we...

@d3lm can you open a bug on wasm-pack and suggest they just the x86-64 binary when running on arm? (for now).

My understanding is the M1 macs do support running x86-64 out of the box (i.e. they ship with whatever tooling they need to make this work).

My understanding is that x86-64 binaries can be executed transparently without any special commands and launch sequences.

Binaryen does provide and x86-64 prebuilt of wasm-opt. I'm suggesting the wasm-opt look for this binary rather than the aarch64 (arm64) version (which doesn't not exist).