emscripten Fix concatenating --pre-js files even if one of the input files has a // comment on the last line

Fix concatenating --pre-js files even if one of the input files has a // comment on the last line

Open juj opened this issue 2 years ago • 2 comments

trafficstars

May 15 '23 10:05 juj

Looks like we lost the actual fix someshow?

It looks like the debug comments that have been added in main have a side-effect of applying the fix.

Sep 02 '24 15:09 juj

Looks like we lost the actual fix someshow?

It looks like the debug comments that have been added in main have a side-effect of applying the fix.

Perhaps we can verify that a newline is implicitly added to the EOF?

Can you assert that the output file contains // a not so innocent comment\n (i.e. include that the newline in the check)?

I would still consider it a (minor) bug if the output contained two comments that run together like this:

// a not so innocent comment// end include: pre.js

Sep 03 '24 17:09 sbc100

Closing old stale PR.

Aug 16 '25 06:08 juj