Maxime U Garcia

Results 406 comments of Maxime U Garcia

cf https://github.com/nf-core/modules/pull/4774

Note that we have overlap with https://github.com/nf-core/modules/issues/3935

cf https://github.com/nf-core/sarek/blob/master/modules/local/build_intervals/main.nf https://github.com/nf-core/raredisease/blob/master/modules/local/create_bed_from_fai.nf

Yeah, let's see if you can make it work

> @maxulysse @tdanhorn @ramprasadn : What do you think about [this](https://github.com/nf-core/sarek/pull/1439)? PURE GENIUS

> Good, though I wonder if it's worth trialling in a pipeline or two for a while before merging into the template? Just because the plugin is very new and...

> > Good, though I wonder if it's worth trialling in a pipeline or two for a while before merging into the template? Just because the plugin is very new...

> @maxulysse , what is the functional change here? Fixing a bug, that is interpreting a `0` not as a string but as an integer, and so an if statement...

> Currently the check has been modified to `if ((meta.lane || meta.lane == 0) && fastq_2) { ...`. I wonder if there is a simpler, possibly even more robust way....

> Thanks for trying! I used the empty string (`""`) as test, because I don't know what the value of a missing lane would be (Groovy is not my native...